mpackdb

7.0 KB

1. import MPackDB, { PrimaryKeyType } from '../src/MPackDB.js';
2. import { rm } from 'fs/promises';
4. const TEST_DB_PATH = 'db/concurrent-find-insert';
6. console.log('--- Concurrent Find-Then-Insert Test ---');
7. console.log('This simulates the exact pattern from login.js:');
8. console.log(' 1. find user by email');
9. console.log(' 2. if not found, insert');
10. console.log(' Called concurrently for the same email.\n');
12. class User {
13. id = null;
14. name = null;
15. email = null;
16. }
18. class Users extends MPackDB {
19. _classToUse = User;
20. _primaryKey = 'id';
21. _primaryKeyType = PrimaryKeyType.UUID;
22. }
24. // --- Raw pattern (no withLock) — demonstrates the race condition ---
26. async function loginFlowRaw(db, label, email) {
27. const [user] = await db.find(u => u.email === email);
28. let userId;
29. if (user) {
30. console.log(` [${label}] Found existing user ${user.id} for ${email}`);
31. userId = user.id;
32. } else {
33. console.log(` [${label}] No user found for ${email}, inserting...`);
34. userId = await db.insert({ email });
35. console.log(` [${label}] Inserted user ${userId} for ${email}`);
36. }
37. return userId;
38. }
40. // --- withLock pattern — the fix ---
42. async function loginFlowLocked(db, label, email) {
43. return db.withLock(async () => {
44. const [user] = await db.find(u => u.email === email);
45. let userId;
46. if (user) {
47. console.log(` [${label}] Found existing user ${user.id} for ${email}`);
48. userId = user.id;
49. } else {
50. console.log(` [${label}] No user found for ${email}, inserting...`);
51. userId = await db.insert({ email });
52. console.log(` [${label}] Inserted user ${userId} for ${email}`);
53. }
54. return userId;
55. });
56. }
58. // ============================================================
59. // PART 1: Raw pattern — shows the problem
60. // ============================================================
61. console.log('=== PART 1: Raw find-then-insert (no lock) ===\n');
63. // TEST 1: Sequential (should pass even without lock)
64. await rm(TEST_DB_PATH, { recursive: true, force: true });
65. const users1 = new Users(`${TEST_DB_PATH}/users`);
67. console.log('TEST 1: Sequential login calls for same email');
68. await loginFlowRaw(users1, 'seq', '[email protected]');
69. await loginFlowRaw(users1, 'seq', '[email protected]');
70. await loginFlowRaw(users1, 'seq', '[email protected]');
71. const seqUsers = await users1.find(u => u.email === '[email protected]');
72. console.log(` Result: ${seqUsers.length} user(s) created (expected: 1)`);
73. console.log(` ${seqUsers.length === 1 ? '✓ PASS' : '✗ FAIL'}\n`);
74. await users1.close();
76. // TEST 2: 2 concurrent (expected to create duplicates without lock)
77. await rm(TEST_DB_PATH, { recursive: true, force: true });
78. const users2 = new Users(`${TEST_DB_PATH}/users`);
80. console.log('TEST 2: 2 concurrent login calls WITHOUT withLock (demonstrates race)');
81. await Promise.all([
82. loginFlowRaw(users2, 'raw2', '[email protected]'),
83. loginFlowRaw(users2, 'raw2', '[email protected]'),
84. ]);
85. const raw2Users = await users2.find(u => u.email === '[email protected]');
86. console.log(` Result: ${raw2Users.length} user(s) created`);
87. console.log(` ${raw2Users.length > 1 ? '⚠ RACE CONFIRMED (duplicates without lock)' : '✓ No race (lucky timing)'}\n`);
88. await users2.close();
90. // TEST 3: 3 concurrent (expected to create duplicates without lock)
91. await rm(TEST_DB_PATH, { recursive: true, force: true });
92. const users3 = new Users(`${TEST_DB_PATH}/users`);
94. console.log('TEST 3: 3 concurrent login calls WITHOUT withLock (demonstrates race)');
95. await Promise.all([
96. loginFlowRaw(users3, 'raw3', '[email protected]'),
97. loginFlowRaw(users3, 'raw3', '[email protected]'),
98. loginFlowRaw(users3, 'raw3', '[email protected]'),
99. ]);
100. const raw3Users = await users3.find(u => u.email === '[email protected]');
101. console.log(` Result: ${raw3Users.length} user(s) created`);
102. console.log(` ${raw3Users.length > 1 ? '⚠ RACE CONFIRMED (duplicates without lock)' : '✓ No race (lucky timing)'}\n`);
103. await users3.close();
105. // ============================================================
106. // PART 2: withLock pattern — proves the fix
107. // ============================================================
108. console.log('=== PART 2: withLock find-then-insert (atomic) ===\n');
110. // TEST 4: Sequential with lock
111. await rm(TEST_DB_PATH, { recursive: true, force: true });
112. const users4 = new Users(`${TEST_DB_PATH}/users`);
114. console.log('TEST 4: Sequential login calls with withLock');
115. await loginFlowLocked(users4, 'lock-seq', '[email protected]');
116. await loginFlowLocked(users4, 'lock-seq', '[email protected]');
117. await loginFlowLocked(users4, 'lock-seq', '[email protected]');
118. const lockSeqUsers = await users4.find(u => u.email === '[email protected]');
119. console.log(` Result: ${lockSeqUsers.length} user(s) created (expected: 1)`);
120. console.log(` ${lockSeqUsers.length === 1 ? '✓ PASS' : '✗ FAIL'}\n`);
121. await users4.close();
123. // TEST 5: 2 concurrent with lock
124. await rm(TEST_DB_PATH, { recursive: true, force: true });
125. const users5 = new Users(`${TEST_DB_PATH}/users`);
127. console.log('TEST 5: 2 concurrent login calls WITH withLock');
128. await Promise.all([
129. loginFlowLocked(users5, 'lock2', '[email protected]'),
130. loginFlowLocked(users5, 'lock2', '[email protected]'),
131. ]);
132. const lock2Users = await users5.find(u => u.email === '[email protected]');
133. console.log(` Result: ${lock2Users.length} user(s) created (expected: 1)`);
134. console.log(` ${lock2Users.length === 1 ? '✓ PASS' : '✗ FAIL'}\n`);
135. await users5.close();
137. // TEST 6: 3 concurrent with lock
138. await rm(TEST_DB_PATH, { recursive: true, force: true });
139. const users6 = new Users(`${TEST_DB_PATH}/users`);
141. console.log('TEST 6: 3 concurrent login calls WITH withLock');
142. await Promise.all([
143. loginFlowLocked(users6, 'lock3', '[email protected]'),
144. loginFlowLocked(users6, 'lock3', '[email protected]'),
145. loginFlowLocked(users6, 'lock3', '[email protected]'),
146. ]);
147. const lock3Users = await users6.find(u => u.email === '[email protected]');
148. console.log(` Result: ${lock3Users.length} user(s) created (expected: 1)`);
149. console.log(` ${lock3Users.length === 1 ? '✓ PASS' : '✗ FAIL'}\n`);
150. await users6.close();
152. // ============================================================
153. // SUMMARY
154. // ============================================================
155. console.log('=== SUMMARY ===');
156. console.log('Without withLock:');
157. console.log(` Sequential: ${seqUsers.length === 1 ? '✓ PASS' : '✗ FAIL'} (${seqUsers.length} users)`);
158. console.log(` 2 concurrent: ${raw2Users.length > 1 ? '⚠ RACE (expected)' : '✓ No race'} (${raw2Users.length} users)`);
159. console.log(` 3 concurrent: ${raw3Users.length > 1 ? '⚠ RACE (expected)' : '✓ No race'} (${raw3Users.length} users)`);
160. console.log('With withLock:');
161. console.log(` Sequential: ${lockSeqUsers.length === 1 ? '✓ PASS' : '✗ FAIL'} (${lockSeqUsers.length} users)`);
162. console.log(` 2 concurrent: ${lock2Users.length === 1 ? '✓ PASS' : '✗ FAIL'} (${lock2Users.length} users)`);
163. console.log(` 3 concurrent: ${lock3Users.length === 1 ? '✓ PASS' : '✗ FAIL'} (${lock3Users.length} users)`);
165. const withLockPass = lockSeqUsers.length === 1 && lock2Users.length === 1 && lock3Users.length === 1;
166. if (!withLockPass) {
167. throw new Error('withLock tests FAILED — concurrent find+insert still produces duplicates');
168. }
169. console.log('\n✓ withLock correctly prevents concurrent duplicates');